Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use periods in target names #104523

Merged
merged 2 commits into from
Nov 30, 2022
Merged

Conversation

flba-eb
Copy link
Contributor

@flba-eb flba-eb commented Nov 17, 2022

@rustbot
Copy link
Collaborator

rustbot commented Nov 17, 2022

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 17, 2022
They can cause issues in e.g. cargo.
@rustbot rustbot added the A-testsuite Area: The testsuite used to check the correctness of rustc label Nov 17, 2022
@flba-eb
Copy link
Contributor Author

flba-eb commented Nov 17, 2022

CC @ehuss

@flba-eb
Copy link
Contributor Author

flba-eb commented Nov 17, 2022

CI output (excerpt) of 5dd073e, before fixing the issue:

platform support check
   Compiling tier-check v0.1.0 (/checkout/src/tools/tier-check)
    Finished release [optimized] target(s) in 1.04s
     Running `obj/build/x86_64-unknown-linux-gnu/stage1-tools/x86_64-unknown-linux-gnu/release/tier-check /checkout/src/doc/rustc/src/platform-support.md /checkout/obj/build/x86_64-unknown-linux-gnu/stage1/bin/rustc`
error: Target name `aarch64-unknown-nto-qnx7.1.0` contains other characters than ASCII alphanumeric (a-z, A-Z, 0-9), dash (-) or underscore (_).
error: Target name `x86_64-pc-nto-qnx7.1.0` contains other characters than ASCII alphanumeric (a-z, A-Z, 0-9), dash (-) or underscore (_).

@flba-eb
Copy link
Contributor Author

flba-eb commented Nov 17, 2022

CC @gh-tr

@flba-eb
Copy link
Contributor Author

flba-eb commented Nov 17, 2022

@wesleywiser and @ehuss , I think this PR is ready for review from your side (especially the test and change/addition in tier 3 policy).
I want to keep it as draft-PR until @gh-tr had the chance to have a look at the QNX/nto related changes as well.

Copy link
Member

@wesleywiser wesleywiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me, thanks!

@flba-eb flba-eb changed the title WIP: Don't use periods in target names Don't use periods in target names Nov 24, 2022
@flba-eb flba-eb marked this pull request as ready for review November 24, 2022 13:51
@rustbot
Copy link
Collaborator

rustbot commented Nov 24, 2022

These commits modify compiler targets.
(See the Target Tier Policy.)

@flba-eb
Copy link
Contributor Author

flba-eb commented Nov 24, 2022

Issue was discussed with @gh-tr and the QNX/Neutrino parts have been approved by him.

@gh-tr
Copy link

gh-tr commented Nov 24, 2022

Confirming. Change makes sense.

@wesleywiser
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Nov 28, 2022

📌 Commit 9c3555d has been approved by wesleywiser

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 28, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 29, 2022
…leywiser

Don't use periods in target names

Using a period in the target name can cause issues in e.g. cargo, see also https://rust-lang.zulipchat.com/#narrow/stream/182449-t-compiler.2Fhelp/topic/Running.20tests.20on.20remote.20target
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 30, 2022
…iaskrgr

Rollup of 14 pull requests

Successful merges:

 - rust-lang#103876 (type alias impl trait: add tests showing that hidden type only outlives lifetimes that occur in bounds)
 - rust-lang#104427 (Explain why `rematch_impl` fails to be infallible)
 - rust-lang#104436 (Add slice to the stack allocated string comment)
 - rust-lang#104523 (Don't use periods in target names)
 - rust-lang#104627 (Print all features with --print target-features)
 - rust-lang#104911 (Make inferred_outlives_crate return Clause)
 - rust-lang#105002 (Add `PathBuf::as_mut_os_string` and `Path::as_mut_os_str`)
 - rust-lang#105023 (Statics used in reachable function's inline asm are reachable)
 - rust-lang#105045 (`rustc_ast_{passes,pretty}`: remove `ref` patterns)
 - rust-lang#105049 (Hermit: Minor build fixes)
 - rust-lang#105051 (Replace a macro with a function)
 - rust-lang#105062 (rustdoc: use shorthand background for rustdoc toggle CSS)
 - rust-lang#105066 (move `candidate_from_obligation` out of assembly)
 - rust-lang#105068 (Run patchelf also on rust-analyzer-proc-macro-srv.)

Failed merges:

 - rust-lang#105050 (Remove useless borrows and derefs)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3e9a223 into rust-lang:master Nov 30, 2022
@rustbot rustbot added this to the 1.67.0 milestone Nov 30, 2022
flba-eb added a commit to flba-eb/ctest2 that referenced this pull request Dec 6, 2022
flba-eb added a commit to flba-eb/ctest2 that referenced this pull request Dec 6, 2022
@workingjubilee workingjubilee added the O-neutrino OS: QNX Neutrino, a POSIX-compatible real-time operating system label Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc O-neutrino OS: QNX Neutrino, a POSIX-compatible real-time operating system S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants